Replace usage of Bundle.module to build outside SPM context #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
approved these changes
Sep 27, 2024
pcuenca
reviewed
Sep 27, 2024
| @@ -202,7 +202,8 @@ public class LanguageModelConfigurationFromHub { | |||
| } | |||
|
|
|||
| static func fallbackTokenizerConfig(for modelType: String) -> Config? { | |||
| guard let url = Bundle.module.url(forResource: "\(modelType)_tokenizer_config", withExtension: "json") else { return nil } | |||
| let bundle = Bundle(for: self) | |||
There was a problem hiding this comment.
We could fix the tests doing something like:
Suggested change
| let bundle = Bundle(for: self) | |
| let bundle = NSClassFromString("XCTest") != nil ? Bundle.module : Bundle(for: self) |
But upon additional testing I found that building a CLI that uses Tokenizers would not find the fallback configuration either.
Do you have any thoughts on that? Some additional ideas:
- Iterate through the bundles and select the right one.
- Create a bundle (or framework?) solely dedicated to hosting the resources.
- Download the fallback configs from a well-known location in the Hub.
|
This turned out trickier than expected, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
Bundle.modulewithBundle(for: self)to accommodate building transformers outside SPM context.